@juliusvonkohout can you kindly advise as part of manifest syncing with script, what other manual action are required when submitting a PR for manifest syncing now please?

@kunal-511 please help out here and adjust the helm chart. Can we make the helm tests non-blocking ?

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml'
from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml' from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

I meant non-blocking for merges, not disabling them. The other option is that you update the helm chart for model registry 0.2.22 and create a PR against @tarilabs branch here.

we can comment out this - 'applications/model-registry/**' and this - '.github/workflows/helm-kustomize-comparison.yml' from https://github.com/kubeflow/manifests/blob/ac32b09acd3afeaa2b9a16e3c0a8943f5ded2496/.github/workflows/helm-kustomize-comparison.yml

I meant non-blocking for merges, not disabling them. The other option is that you update the helm chart for model registry 0.2.22 and create a PR against @tarilabs branch here.

I have raised the PR against the @tarilabs branch to update helm charts values

I've accepted PR from @kunal-511 but I'm still confused if the process to update the manifest iwth the script must now also include Helm manifest changes.

@juliusvonkohout can you kindly advise.
ie

Can we make the helm tests non-blocking ?

I suppose we still will need to make the helm tests non-blocking (#3216 (comment))

I've accepted PR from @kunal-511 but I'm still confused if the process to update the manifest iwth the script must now also include Helm manifest changes.

@juliusvonkohout can you kindly advise. ie

Can we make the helm tests non-blocking ?

I suppose we still will need to make the helm tests non-blocking (#3216 (comment))

I think we have to make the Helm charts non-blocking or Kunal needs to extend the scripts for helm.

@kunal-511 also here as in all other PRs the CI/Cd is failing with training-operator.

@kunal-511 also here as in all other PRs the CI/Cd is failing with training-operator.

Yes debugging it

/lgtm
/approve

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout

The full list of commands accepted by this bot can be found here.

The pull request process is described here